aaron.ballman added a comment.

Should we also be updating InitPreprocessor.cpp at the same time, for 
non-Windows targets? I see we define:

  // TS features.
  if (LangOpts.Coroutines)
    Builder.defineMacro("__cpp_coroutines", "201703L");

but we don't define `__cpp_­impl_­coroutine`: 
http://eel.is/c++draft/tab:cpp.predefined.ft

And this should definitely come with a release note so users know about the 
change in status.



================
Comment at: clang/www/cxx_status.html:1225
         <details><summary>Partial</summary>
-          The optimizer does not yet handle TLS with
-  <tt>__attribute__((const))</tt> attribute correctly. There can be issues 
where the
-  coroutine may resume on a different thread. <br \>This feature requires 
further
-  analysis of the C++ Standard to determine what work is necessary for 
conformance.
+          It's supported fully everywhere but on Windows targets.
         </details></td>
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146187/new/

https://reviews.llvm.org/D146187

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to