hokein added a comment. Thanks for the review.
In D146202#4198904 <https://reviews.llvm.org/D146202#4198904>, @ChuanqiXu wrote: > Yeah, this one should be correct. Modules techniques use `*::Profile` method > to judge if two entities are the same extensively. So it would be best to add > a test case for modules like we did in > https://reviews.llvm.org/rG3e78fa860235431323aaf08c8fa922d75a7cfffa. And it > doesn't matter if you are not interested, I'll take it later then. I'm landing the patch as-is now. It would be nice for you to add a related test for modules afterwards (since I don't have much knowledge about clang module stuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146202/new/ https://reviews.llvm.org/D146202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
