kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land.
Thank you @bryanpkc, this LGTM ================ Comment at: clang/test/CodeGen/aarch64-sme-intrinsics/acle_sme_read.c:2 +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme -target-feature +sve -S -O1 -Werror -emit-llvm -o - %s | FileCheck %s -check-prefixes=CHECK,CHECK-C +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sme -target-feature +sve -S -O1 -Werror -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,CHECK-CXX ---------------- bryanpkc wrote: > kmclaughlin wrote: > > I think `-target-feature +sve` can be removed from this test and > > `acle_sme_write.c` > Doing that will cause errors like these: > ``` > error: SVE vector type 'svbool_t' (aka '__SVBool_t') cannot be used in a > target without sve > ``` > As I have explained in [D127910](https://reviews.llvm.org/D127910#4137844), > `-target-feature +sme` does not imply `-target-feature +sve`. But `-march=` > processing will work as expected when D142702 lands. Apologies for leaving the same comment, I missed this on the previous patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llvm.org/D128648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
