alexfh added inline comments.

================
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:119
@@ -115,1 +118,3 @@
     StringRef EscapedCommandLine) {
+#if defined(LLVM_ON_WIN32)
+  llvm::BumpPtrAllocator Alloc;
----------------
As noted on D23409, this will likely break mingw compatibility in clang on 
windows. We should either add a sort of auto-detection of the command line 
format, or extend the JSON compilation database with a way to specify the 
command line format used (or as Reid suggests, specify a list of arguments, but 
this should be done in a backward-compatible way).


https://reviews.llvm.org/D23455



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to