jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, make sure all tests pass, this one seems to fail according to build kite: 
OpenMP/target_map_codegen_hold.cpp



================
Comment at: clang/test/OpenMP/target_map_codegen_hold.cpp:211
+// CHECK-NOUSE-I386: @llvm.global_ctors = appending global [1 x { i32, ptr, 
ptr }] [{ i32, ptr, ptr } { i32 0, ptr @.omp_offloading.requires_reg, ptr null 
}]
+//.
 // CHECK-USE-PPC64LE-LABEL: define {{[^@]+}}@_Z20explicit_maps_singlei
----------------
The hash is hardcoded. I recommend removing this part and putting the old check 
lines in again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145820/new/

https://reviews.llvm.org/D145820

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to