w2yehia accepted this revision.
w2yehia added a comment.
This revision is now accepted and ready to land.
LGTM. Would be nice to get @daltenty 's approval too.
================
Comment at: clang/test/Driver/aix-ld.c:1094
+// CHECK-RELOCATABLE-NOT: "[[SYSROOT]]/usr/lib{{/|\\\\}}crti.o"
+// CHECK-RELOCATABLE-NOT: "-lc++"
+// CHECK-RELOCATABLE-NOT: "-lc++abi"
----------------
is there a way to check that `-l<anything>` is not present?
I'm thinking it's more future-proof ((1) detects if new libraries get added and
(2) avoids having to update the testcase).. not sure what the disadvantages of
adding the wildcard is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145899/new/
https://reviews.llvm.org/D145899
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
