yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:442
+ llvm::sys::Process::GetEnv("HIP_PATH")) {
+ if (!HIPPathEnv->empty()) {
+ HIPSearchDirs.emplace_back(std::move(*HIPPathEnv));
----------------
tra wrote:
> Style nit. Single-statement if body should be w/o `{}`.
will fix
================
Comment at: clang/test/Driver/rocm-detect.hip:42
+
+// RUN: rm -rf %T/myhip
+// RUN: rm -rf %T/myhip_nouse
----------------
MaskRay wrote:
> `%T` is not recommended.
>
> https://llvm.org/docs/CommandGuide/lit.html
> "parent directory of %t (not unique, deprecated, do not use)"
>
> Just use `RUN: rm -rf %t && mkdir %t`
>
I will use %t/myhip, as I need a deterministic unique name to check that it is
used
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145391/new/
https://reviews.llvm.org/D145391
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
