hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Preamble.cpp:942
MainFileMacros PreamblePatch::mainFileMacros() const {
if (PatchContents.empty())
----------------
nit: maybe just return a `const MainFileMacros&`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146028/new/
https://reviews.llvm.org/D146028
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
