hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
LGTM
I've always found this to be an interesting behavior, and I'm guessing you
found some code where it does matter :)
================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2612
+ if (Context.getTargetInfo().getCXXABI().isMicrosoft() ||
+ Context.getTargetInfo().getTriple().isPS()) {
if (Attr *ClassAttr = getDLLAttr(Class)) {
----------------
Would using `getTargetInfo().shouldDLLImportComdatSymbols()` be appropriate
here now?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145970/new/
https://reviews.llvm.org/D145970
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
