dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks alright - thanks! :)
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3962
int InitialOffset = std::get<1>(Vec[0]);
- AnyConsecutive |= all_of(enumerate(Vec), [InitialOffset](auto &P) {
+ AnyConsecutive |= all_of(enumerate(Vec), [InitialOffset](auto &&P) {
return std::get<1>(P.value()) == int(P.index()) + InitialOffset;
----------------
I'd probably pass by const ref here - the forwarding ref seems a bit more
general than needed/looks like there could be ownership transfer, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145987/new/
https://reviews.llvm.org/D145987
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
