agozillon added a comment. Recent update was to simplify the omp-frontend-forwarding.f90 test
================ Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + ---------------- awarzynski wrote: > Given that you use `-###`, I think that this can be skipped (please double > check). It does appear that it can be, at the very least I can swap in an NVIIDIA arch when I haven't configured the project to target it and it has no issues! Thank you. ================ Comment at: flang/test/Driver/omp-frontend-forwarding.f90:13 +! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "aarch64-unknown-linux-gnu" {{.*}} "-fopenmp" {{.*}}.f90" +! CHECK-NOT: "{{[^"]*}}flang-new" "-fc1" "-triple" "aarch64-unknown-linux-gnu" {{.*}} "-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90" +! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}} "-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90" ---------------- awarzynski wrote: > I feel that you can safely remove this line and replace the following with > `CHECK-NEXT`, no? Just wondering whether there's a way to reduce the noise in > these tests (without sacrificing the rigor). I can indeed, thank you very much @awarzynski! I have a knack for overcomplicating these it seems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits