gribozavr2 added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:22
+
+// A logger is notified as the analysis progresses.
+// It can produce a report of the analysis's findings and how it came to them.
----------------
Elsewhere under Analysis/FlowSensitive we use triple slash as a doc comment
marker - could you make the new header follow the pattern?
================
Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:23
+// A logger is notified as the analysis progresses.
+// It can produce a report of the analysis's findings and how it came to them.
+//
----------------
================
Comment at: clang/include/clang/Analysis/FlowSensitive/Logger.h:38
+ // Forms a pair with endAnalysis().
+ virtual void beginAnalysis(const ControlFlowContext &,
+ TypeErasedDataflowAnalysis &) {}
----------------
Why not DataflowAnalysisContext instead of ControlFlowContext?
You can reach the latter from the former, but not vice versa.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144730/new/
https://reviews.llvm.org/D144730
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
