aaron.ballman added inline comments.

================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1949
+  // Pointer of derived type is already on the stack.
+  const CXXRecordDecl *FinalDecl = cast<CXXRecordDecl>(BaseType->getDecl());
+  const RecordDecl *CurDecl = DerivedType->getDecl();
----------------



================
Comment at: clang/test/AST/Interp/records.cpp:266
 };
 #endif
 
----------------
I think it'd be good to add test coverage for cases like: 
https://godbolt.org/z/GnPnP4z76


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143480/new/

https://reviews.llvm.org/D143480

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to