rymiel marked an inline comment as done.
rymiel added inline comments.

================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3393
+        break;
+      } else {
+        return;
----------------
HazardyKnusperkeks wrote:
> don't need `else` after `break`.
> In fact I would negate the condition and return, and keep the remainder out 
> of any `if` or `else`.
Thank you! I clearly wasn't thinking clearly there


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145642/new/

https://reviews.llvm.org/D145642

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to