vedgy marked an inline comment as not done. vedgy added inline comments.
================ Comment at: clang/include/clang-c/Index.h:365 + */ + int ExcludeDeclarationsFromPCH : 1; + /** ---------------- vedgy wrote: > Assigning `true` to `int : 1` bit-fields in C++ code produces a GCC warning: > ``` > warning: overflow in conversion from ‘int’ to ‘signed char:1’ changes value > from ‘1’ to ‘-1’ [-Woverflow] > ``` > > Following a suggestion in a comment to > https://github.com/llvm/llvm-project/issues/53253, I replaced this `int` with > `unsigned` and the warning disappeared. Same for `int DisplayDiagnostics : > 1`. Should this type change be included in the upcoming > `StorePreamblesInMemory` revision? Or should this change be done in a separate revision, on which the `StorePreamblesInMemory` would be based? I also implemented two other changes to the `struct CXIndexOptions` (mostly documentation/comments). Should these all be in separate revisions or combined into one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143418/new/ https://reviews.llvm.org/D143418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
