ilya-biryukov added a comment. I don't have a lot of experience in codegen, so will let Aaron and Richard do the review.
However, still wanted to share one observation. The actual check that avoids emitting the destructors for variables seems more involved than just checking if the destructor is `constexpr`. Is it safe to rely solely on the type for codegen? E.g. I would have expected checks that look at `HasConstantDestruction` for variables with non-trivial constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/ https://reviews.llvm.org/D145369 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
