t-rasmud added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1079
+ dyn_cast<DeclRefExpr>(ArraySub->getBase()->IgnoreImpCasts())) {
+ // FIXME: this `getASTContext` call is costy, we should pass the
+ // ASTContext in:
----------------
Nit: "costly"
================
Comment at:
clang/test/SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp:74
+ // CHECK-NOT: fix-it:"{{.*}}":{[[@LINE-1]]
+}
----------------
Can we have a test case for `&p[0]`?
IIUC, this would generate a fixit `p.data() + 0` which is correct but we might
want to optimize it to `p.data()` sometime in the future.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143128/new/
https://reviews.llvm.org/D143128
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
