john.brawn added a comment. In D144654#4156430 <https://reviews.llvm.org/D144654#4156430>, @aaron.ballman wrote:
> This seems to cause precommit CI failures that should be addressed, and it > should also have a release note about the fix. Failures in CI should be fixed by D145397 <https://reviews.llvm.org/D145397> and D144651 <https://reviews.llvm.org/D144651>. I'll also add a release note. > Also, should this cover things like `clang -U__cplusplus -D__STDC__=1 > foo.cpp` as well? Yes, and I'll add tests for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144654/new/ https://reviews.llvm.org/D144654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits