AlexanderHederstaf requested review of this revision.
AlexanderHederstaf added a comment.

Refactored using the NonComment() functions and added some tests to verify that 
it works correctly.

In D144709#4171029 <https://reviews.llvm.org/D144709#4171029>, @MyDeveloperDay 
wrote:

> I might have been tempted to handle the comments in a separate commit, I 
> don't like to do too much in one go or the review gets hard to manage.

I had the same thought but as the comments change is not only an extension of 
the capability I included it to be safe. Without the change it would lead to 
code that doesn't compile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144709/new/

https://reviews.llvm.org/D144709

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to