dblaikie added a comment.

Haven't followed the patch in detail - but why does this require changes to the 
RecordLayout code? (I'd expect this to only require charnges to the debug info 
code - maybe with a shared helper utility function that both the AMDGPU ABI 
implementation, and the debug info can use to observe this property, if it's 
non-trivial code to duplicate in both places? (but doesn't look like it's 
sharing code with the ABI implementation, or moving the logic out of the ABI 
implementation into the record layout code for reuse there))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144870/new/

https://reviews.llvm.org/D144870

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D144... David Blaikie via Phabricator via cfe-commits
    • [PATCH]... Juan Manuel Martinez Caamaño via Phabricator via cfe-commits
    • [PATCH]... Paul Robinson via Phabricator via cfe-commits
    • [PATCH]... Juan Manuel Martinez Caamaño via Phabricator via cfe-commits
    • [PATCH]... Juan Manuel Martinez Caamaño via Phabricator via cfe-commits
    • [PATCH]... Paul Robinson via Phabricator via cfe-commits

Reply via email to