ccotter marked an inline comment as done.
ccotter added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/cppcoreguidelines/RvalueReferenceParamNotMovedCheck.cpp:110
+ const auto *MoveCall = Result.Nodes.getNodeAs<CallExpr>("move-call");
+ if (!MoveCall) {
+ diag(Param->getLocation(),
----------------
PiotrZSL wrote:
> consider style:
> if (MoveCall) return;
>
>
I left this as is as I recall seeing on other phabs a preference towards
keeping the curly braces for expressions that (after taking into account line
length style rules) span multiple lines. I think it helps my own readability in
these situations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141569/new/
https://reviews.llvm.org/D141569
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
