andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land.
This looks good to me. I'm adding @rjmccall as a reviewer to make sure someone with front end expertise sees this. There seems to be a potential type mismatch between the intrinsic and the builtin in the case of __builtin_flt_rounds(). Based on D24461 <https://reviews.llvm.org/D24461>, I wonder if that's a target-specific difference. I'm not sure if a similar issue exists in this case since we aren't copying a gcc builtin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144454/new/ https://reviews.llvm.org/D144454 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
