erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land.
I don't have a great idea of this section of code, but as code-owner I guess I'm stuck approving/disapproving of this :) Barring additional information, I think I have to accept this approach, it seems to work right, and from some time debugging, it at least doesn't seem like the 'wrong' answer here. I think the suggestion corentin made is correct and needs to be made, but otherwise I consider this acceptable. ================ Comment at: clang/include/clang/AST/DeclCXX.h:1553 + bool isDerivedFrom(const CXXRecordDecl *Base, + bool LookupIndependent = false) const; ---------------- cor3ntin wrote: > Ditto in the rest of the patch I suggest making this just `LookupInDependentTypes` to be more clear. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143840/new/ https://reviews.llvm.org/D143840 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
