nridge created this revision.
nridge added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
The second argument to string::substr() is a count,
not an end position.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D144453
Files:
clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
Index: clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
+++ clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
@@ -157,7 +157,8 @@
std::string TweakTest::decorate(llvm::StringRef Code,
llvm::Annotations::Range Range) {
return (Code.substr(0, Range.Begin) + "[[" +
- Code.substr(Range.Begin, Range.End) + "]]" + Code.substr(Range.End))
+ Code.substr(Range.Begin, Range.End - Range.Begin) + "]]" +
+ Code.substr(Range.End))
.str();
}
Index: clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
+++ clang-tools-extra/clangd/unittests/tweaks/TweakTesting.cpp
@@ -157,7 +157,8 @@
std::string TweakTest::decorate(llvm::StringRef Code,
llvm::Annotations::Range Range) {
return (Code.substr(0, Range.Begin) + "[[" +
- Code.substr(Range.Begin, Range.End) + "]]" + Code.substr(Range.End))
+ Code.substr(Range.Begin, Range.End - Range.Begin) + "]]" +
+ Code.substr(Range.End))
.str();
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
