jmmartinez added inline comments.
================ Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags, AlignInBits); ---------------- I'll be tempted to move the call to `getSubprogramNodesTrackingVector(Scope)` into `createLocalVariable`. It seems that every time `createLocalVariable` is called, `getSubprogramNodesTrackingVector(Scope)` is passed as value for `PreservedNodes`. (I've just started reviewing so I may be missing some other modifications) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
