klimek added inline comments.
================ Comment at: clang/lib/Format/UnwrappedLineParser.h:287 // owned outside of and handed into the UnwrappedLineParser. + // FIXME: The above fixme doesn't work if we need to create tokens while + // parsing. ---------------- sammccall wrote: > I'm not really sure how to read the combination of these two FIXMEs... does > it mean "we wanted to do this differently one day, but now we never can"? > > Maybe either delete both, or if you think it's still potentially actionable, > something like FIXME: it would be better to have tokens created and owned > outside because XYZ, but it's hard because macro expansion mutates the stream > > (I don't really understand what the prev comment is about: the tokens *are* > handed into the UnwrappedLineParser constructor. So I may be off base here) Yeah, I think I don't fully understand what I wanted to fix, so deleted both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143070/new/ https://reviews.llvm.org/D143070 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
