phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/include/clang/Driver/MultilibBuilder.h:117 + /// Add an optional Multilib segment + MultilibSetBuilder &Maybe(const MultilibBuilder &M); + ---------------- MaskRay wrote: > Use `camelCase` for new function names. These functions were copies from the existing `MultilibSet` class so I'm fine keeping the original names to reduce the amount of changes. If we decide to change the names, it would ideally be done in a follow up change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://reviews.llvm.org/D142893 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
