inclyc added inline comments.
================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315 + if (Subtarget.hasVendorXTHeadBb()) { + setOperationAction({ISD::CTLZ}, XLenVT, Legal); + ---------------- It looks like this line of code will cause compilation warning. ``` [1677/1717] Building CXX object lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o /tmp/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315:24: warning: braces around scalar initializer [-Wbraced-scalar-init] setOperationAction({ISD::CTLZ}, XLenVT, Legal); ^~~~~~~~~~~ 1 warning generated. [1717/1717] Creating library symlink lib/libclang-cpp.so [1542/1716] Building CXX object lib/Target/RISCV/CMakeFiles/LLVMRISCVCodeGen.dir/RISCVISelLowering.cpp.o /tmp/llvm-project/llvm/lib/Target/RISCV/RISCVISelLowering.cpp:315:24: warning: braces around scalar initializer [-Wbraced-scalar-init] setOperationAction({ISD::CTLZ}, XLenVT, Legal); ^~~~~~~~~~~ 1 warning generated. [1716/1716] Linking C executable bin/mlir-capi-execution-engine-test ``` ================ Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:320 + if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } ---------------- And this one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143439/new/ https://reviews.llvm.org/D143439 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits