DmitryPolukhin added a comment. In D143436#4120899 <https://reviews.llvm.org/D143436#4120899>, @nridge wrote:
> Note that D138546 <https://reviews.llvm.org/D138546> is removing the call to > `inferTargetAndDriverMode()` from `GlobalCompilationDatabase.cpp`. It adds > equivalent logic too `CommandMangler` which is used for CDBs pushed from LSP > as well, so it accomplishes objective of this patch with respect to > `inferTargetAndDriverMode` (but not `inferMissingCompileCommands`). @nridge I think D138546 <https://reviews.llvm.org/D138546> solves the issue only partially and we need both patches applied. `inferMissingCompileCommands` and `expandResponseFiles` also needs to be applied to command pushed via LSP. I can rebase on top of D138546 <https://reviews.llvm.org/D138546> if it will be landed first and update test. Please advise which patch should land first? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
