aprantl added a comment.
Nice! Does `expr -- std::basic_string<char> s` still work after this change?
Not that anyone would want to type this over `std::string` ...
================
Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1
+// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o -
-debugger-tuning=lldb | FileCheck --check-prefixes=COMMON,LLDB %s
+// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o -
-debugger-tuning=gdb | FileCheck --check-prefixes=COMMON,GDB %s
----------------
Is `-debug-info-kind=limited` needed here? Using it here is odd since LLDB
doesn't really support it and favors `=standalone` instead.
================
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61
if self.expectedCompilerVersion(['>', '16.0']):
+ string_type = "std::string"
----------------
Out of curiosity: How does this function work when building the testsuite with
a compiler that isn't Clang?
I vaguely recall there was someone in the community running a bot that built
the LLDB testsuite against GCC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143501/new/
https://reviews.llvm.org/D143501
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
