balazske added a comment.

Probably it is not always useful to explain why the argument is wrong. In cases 
when we can find out that the value is exactly between two consecutive valid 
ranges we can display a note, or when the exact value is known. Otherwise it 
may end up in something like "the value should be between 1 and 4 or between 6 
and 10, but it is less than 1 or exactly 5 or greater than 10". The "good" 
cases are (when more information is available): "the value is less than 1", 
"the value is 5", "the value is greater than 10". If two bad ranges are known 
it may be OK too: "the value is less than 1 or it is exactly 5". The 
explanation may be possible to implement by test assumes for the negated ranges.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143194/new/

https://reviews.llvm.org/D143194

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to