ahatanak added a comment.

I agree that pushing an empty scope without initializing any of its members 
seems wrong.

Instead of doing that, the updated patch changes the decl context instead if we 
are trying to capture a variable in a default argument expression of a lambda 
call operator. I think that's okay since the type of the `DeclRefExpr` of the 
variable appearing in the default argument expression shouldn't depend on 
whether it's captured by the lambda, if I understand the standard rules 
correctly (note that when clang crashes, `tryCaptureVariable` is being called 
by `getCapturedDeclRefType`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143109/new/

https://reviews.llvm.org/D143109

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to