kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/FindTarget.cpp:1047 + bool TraverseTypeConstraint(const TypeConstraint *TC) { + Out(ReferenceLoc{TC->getNestedNameSpecifierLoc(), ---------------- can you also add a comment like `// We actually want to handle all ConceptReferences but RAV doesn't traverse it polymorphically. So handle the ones inside TypeConstraints specially here.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142871/new/ https://reviews.llvm.org/D142871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits