tbaeder marked 2 inline comments as done.
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:34-35
+ virtual ~DeclScope() override { this->emitDestruction(); }
+
void addExtended(const Scope::Local &Local) override {
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > The destructor for `LocalScope` already calls `emitDestruction()` which is
> > a virtual function, so is this necessary?
> Still wondering about this
You're right, removed it again. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138802/new/
https://reviews.llvm.org/D138802
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
