sammccall marked 2 inline comments as done.
sammccall added inline comments.
================
Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:18
static llvm::StringRef *HeaderNames;
+static struct SymbolName {
----------------
hokein wrote:
> nit: we group five symbols together, it is a bit hard to follow.
>
> Can you move the HeaderNames just before the `HeaderIDs` and mention the
> value of the `HeaderIDs` is the index of `HeaderNames`?
Rearranged these and added comments to each.
================
Comment at: clang/lib/Tooling/Inclusions/Stdlib/StandardLibrary.cpp:108
+ std::vector<Symbol> Result;
+ Result.reserve(HeaderIDs->size());
+ for (unsigned I = 0, E = SymbolCount; I < E; ++I)
----------------
hokein wrote:
> should be `SymbolCount`.
Oops, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142467/new/
https://reviews.llvm.org/D142467
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
