hokein added a comment.
Thanks!
The changes in C++ mapping are good in general. Most removals are reasonable,
my only concern is the removal of `std::{begin, end, size, empty, data}` (as
they are now provided by multiple headers), IMO these are important symbols (no
action needed in this patch, I added them back manually as part of the
c-compatibility header change https://reviews.llvm.org/D143160).
================
Comment at: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc:12
-SYMBOL(ATOMIC_BOOL_LOCK_FREE, None, <stdatomic.h>)
-SYMBOL(ATOMIC_CHAR16_T_LOCK_FREE, None, <stdatomic.h>)
----------------
We're removing many macros, macros seems to be moved out to a separated page
(https://en.cppreference.com/w/c/symbol_index/macro) in the latest cppreference
snapshot, there are some more work needed to update this file. Let's postpone
it and focus on the C++ symbols in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143054/new/
https://reviews.llvm.org/D143054
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
