jkorous added inline comments.
================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:894
+ if (VD->getType()->isPointerType())
+ return fixVariableWithSpan(VD, Tracker, Ctx, Handler);
+ return {};
----------------
I believe we should add another condition here: `VD->isLocalVarDecl()` as we
don't support globals (yet?).
We run the matcher with `any_ds` tag only on function bodies so we won't
discover globals anyway and the `assert(It != Defs.end() && "Definition never
discovered!");` would fail.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139737/new/
https://reviews.llvm.org/D139737
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
