kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/ConfigFragment.h:243 + /// - Strict + std::optional<Located<std::string>> Mode; + ---------------- sammccall wrote: > I think "Diagnostics.Mode" is too vague a name. > > I expect this to be a rollout flag that we remove in the medium term (either > deciding to stick to the old or new behavior), so maybe something > ultra-specific like`AllowStalePreamble: yes/no`? > (Preamble is jargon, maybe there's something better, but again I don't think > we should plan for this to be really "user-visible") i actually feel like there's some value in keeping this around. some users value correctness of their diagnostics too much, and option isn't really costly to implement. why do you think we should stick to one or the other? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142890/new/ https://reviews.llvm.org/D142890 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
