miyuki added inline comments.
================
Comment at: clang/lib/Driver/Multilib.cpp:82
+ for (const Matcher &M : Matchers) {
+ const std::regex Regex(M.Regex);
+ if (std::find_if(InFlags.begin(), InFlags.end(),
----------------
Please use the LLVM regular expression engine (llvm/Support/Regex.h) instead of
std::regex. It's more portable, e.g., I've seen bugs and performance issues
with MSVC implementation that don't manifest on Linux.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142932/new/
https://reviews.llvm.org/D142932
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
