arsenm added inline comments.

================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:12477-12480
+  F->setCallingConv(llvm::CallingConv::AMDGPU_KERNEL);
+
+  // FIXME: Apply default attributes
+  F->addFnAttr(llvm::Attribute::NoUnwind);
----------------
yaxunl wrote:
> need a test
It's already tested, I recommitted the regression test in 
7f2f6eec3ead9c5715c86159919d6df182d1cc4d. This is supposed to be NFC


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141447/new/

https://reviews.llvm.org/D141447

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to