erikdesjardins added inline comments.
================ Comment at: llvm/test/DebugInfo/X86/gnu-public-names.ll:68-71 ; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL +; ASM-NEXT: .asciz "ns::global_namespace_variable" # External Name +; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL ; ASM-NEXT: .asciz "global_variable" # External Name ---------------- Previously, this was ``` ; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL ; ASM-NEXT: .asciz "global_variable" # External Name ...more lines... ; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL ; ASM-NEXT: .asciz "ns::global_namespace_variable" # External Name ``` but the reordering resulted in there being another `.byte 32` (a very fragile check line!) before `global_variable`. ================ Comment at: llvm/test/DebugInfo/X86/gnu-public-names.ll:189 -; CHECK: DW_TAG_subprogram +; CHECK: [[GLOBAL_F7:0x[0-9a-f]+]]: DW_TAG_subprogram +; CHECK: DW_AT_linkage_name ---------------- Similarly here--`f7` used to be at the end of the list below, and was just ignored, but now it appears in the middle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
