benshi001 added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AVR.cpp:500 - if (SectionAddressData) { - CmdArgs.push_back(Args.MakeArgString( - "-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); - } else { - // We do not have an entry for this CPU in the address mapping table yet. - D.Diag(diag::warn_drv_avr_linker_section_addresses_not_implemented) << CPU; + // If user explicitly specifies a linker script, we should follow that. + // Otherwise we must add a default '-Tdata' option to the linker, according ---------------- I have added comment about why we need this change, it has nothing to do with https://github.com/llvm/llvm-project/issues/60203. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142595/new/ https://reviews.llvm.org/D142595 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits