iains marked an inline comment as done.
iains added a comment.
in my local testing, I was able to consume all libc++ headers individually.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:15265
FD->getFormalLinkage() == Linkage::ExternalLinkage &&
- !FD->isInvalidDecl() && BodyKind != FnBodyKind::Delete &&
+ !FD->isInvalidDecl() && !IsFnTemplate && BodyKind != FnBodyKind::Delete
&&
BodyKind != FnBodyKind::Default && !FD->isInlined()) {
----------------
rsmith wrote:
> Would it make sense to use `!isa<FunctionTemplateDecl>(D)` here instead of
> adding `IsFnTemplate`?
> Would it make sense to use `!isa<FunctionTemplateDecl>(D)` here instead of
> adding `IsFnTemplate`?
I have changed this to use FD->isTemplated() to match the changes for VarDecls
- where the template decl is not available. Would it be better to use the
isa<>() ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142704/new/
https://reviews.llvm.org/D142704
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
