sammccall added inline comments.

================
Comment at: clang/test/AST/ast-dump-attr-type.cpp:12
+// CHECK-NEXT:        `-BuiltinType 0x{{[^ ]*}} 'int'
+// CHECK-NOT:       `-PointerType 0x564c31a07520 'int *'
----------------
gribozavr2 wrote:
> sammccall wrote:
> > Can you add a second example where the attribute is not mere sugar, showing 
> > that both types get printed?
> > 
> > The example from the AttributedType doc is `vector_size`, which would work
> Please replace the exact pointer value with a regex.
Oops, yes. In fact just `CHECK-NOT: PointerType` seems like enough


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142637/new/

https://reviews.llvm.org/D142637

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D142637... Sam McCall via Phabricator via cfe-commits
    • [PATCH] D1... Dmitri Gribenko via Phabricator via cfe-commits
    • [PATCH] D1... Sam McCall via Phabricator via cfe-commits
    • [PATCH] D1... Dani Ferreira Franco Moura via Phabricator via cfe-commits
    • [PATCH] D1... Dani Ferreira Franco Moura via Phabricator via cfe-commits
    • [PATCH] D1... Dani Ferreira Franco Moura via Phabricator via cfe-commits

Reply via email to