aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/AST/TypePrinter.cpp:2018 + + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); ---------------- nit: `.` at the end. ================ Comment at: clang/lib/AST/TypePrinter.cpp:2019 + // Can't evaluate value-dependent expressions so bail early + Expr const *pattern_expr = Pattern.getAsExpr(); + if (pattern_expr->isValueDependent() || ---------------- I assume you checked that this is always non-null? ================ Comment at: clang/lib/AST/TypePrinter.cpp:2031 + if (args_expr->isValueDependent() || !args_expr->isIntegerConstantExpr(Ctx)) + return false; + ---------------- Just for my own education: what's an example for a value-dependent constant integer expression? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142632/new/ https://reviews.llvm.org/D142632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
