Michael137 added a comment.

Latest diff now sets the `IsDefaulted` flag from 
`Sema::CheckTemplateArgumentList`, which is the best point I could find for 
creation of `TemplateArgument` which are fed into the various specialization 
decls (and later on the `TypePrinter`).

The review description has some additional info about the changes.

As a result of moving the `isSubstitutedDefaultArgument` higher up into `Sema`, 
we can simplify the other remaining callers:

- https://reviews.llvm.org/D141827
- https://reviews.llvm.org/D142333

Still unsure if changing the `TemplateArgument` constructors is cleaner than 
simply calling `setIsDefaulted` from the tablegen creators but I'm open to 
suggestions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141826/new/

https://reviews.llvm.org/D141826

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to