v1nh1shungry added inline comments.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:994
HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP));
+ PassType.PassBy = getPassMode(PVD->getType());
+ }
----------------
kadircet wrote:
> sorry for showing up late to the party but instead of changing rest of the
> code, can we apply this logic only when there are no implicit
> casts/conversions between the arg and callexpr (i.e `N == &OuterNode`)?
To make sure I understand it correctly, do you mean I should give up any other
code changes I made but keep this logic, and put this logic into the `N ==
&OuterNode` branch?
Sorry if I misunderstood anything! Shame for not being a good reader :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142014/new/
https://reviews.llvm.org/D142014
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
