aaron.ballman added inline comments.
================
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs<IntegerLiteral>("literal");
- const auto *Cast = Result.Nodes.getNodeAs<Expr>("cast");
- bool LiteralBooleanValue = Literal->getValue().getBoolValue();
+ for (const auto &BindingName :
+ {"literal", "trueBranchLiteral", "falseBranchLiteral"}) {
+ const auto *Literal = Result.Nodes.getNodeAs<IntegerLiteral>(BindingName);
----------------
omtcyfz wrote:
> aaron.ballman wrote:
> > Any reason not to name the bind "literal" in all three cases? That
> > eliminates the need for the loop entirely, since `check()` will trigger for
> > each instance of a match.
> It doesn't make sense to try binding both `TrueExpression` and
> `FalseExpression` literals to a single value.
Why? In all three cases, you don't care what matched, just that *some* case is
matched. None of the logic in `check()` relies on which part of the expression
is matched.
https://reviews.llvm.org/D23243
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
