thesamesam added inline comments.

================
Comment at: clang/bindings/python/tests/cindex/util.py:82
+# our tests.
+os.environ["CLANG_NO_DEFAULT_CONFIG"] = "1"
 
----------------
xen0n wrote:
> This is essentially an import-time side effect, IMO it could be better to 
> instead put the envvar provision in 
> `clang/bindings/python/tests/CMakeLists.txt`: the `add_custom_target` there 
> already is making use of `env` so should be relatively easy to stuff this 
> there too.
I hesitated to do that because it doesn't vary with the environment at all (the 
test should never really be run with custom configs), but given you've 
suggested it, that tips the balance on me being undecided - so I'll implement 
that now. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141248/new/

https://reviews.llvm.org/D141248

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to