nridge added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:15186 + if (ChildExpr == CSE->getOperand()) + // Do not recurse over a CoroutineSuspendExpr's operand. + // The operand is also a subexpression of getCommonExpr(), and ---------------- Out of curiosity, since `getCommonExpr()` is itself a subexpression of `getReadyExpr()`, `getSuspendExpr()`, and `getResumeExpr()` (which are also children of the `CoroutineSuspendExpr`), shouldn't `getCommonExpr()` be skipped for the same reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142077/new/ https://reviews.llvm.org/D142077 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
